Skip to content

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Jan 26, 2026

Summary

Issue: QOV-1533

This PR corrects an issue where the override values of TF variables were not trimmed.

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

@rmnbrd rmnbrd self-assigned this Jan 26, 2026
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.81%. Comparing base (b1b3137) to head (40107cf).
⚠️ Report is 3 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2328      +/-   ##
===========================================
- Coverage    47.73%   46.81%   -0.93%     
===========================================
  Files         1254      149    -1105     
  Lines        22717     3559   -19158     
  Branches      6635     1087    -5548     
===========================================
- Hits         10844     1666    -9178     
+ Misses        9808     1532    -8276     
+ Partials      2065      361    -1704     
Flag Coverage Δ
unittests 46.81% <ø> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit 0f3e58b into staging Jan 26, 2026
9 of 10 checks passed
@rmnbrd rmnbrd deleted the fix/tf-variables/trim-new-lines-QOV-1533 branch January 26, 2026 10:59
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.271.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants