Skip to content

Conversation

@pggb25
Copy link
Collaborator

@pggb25 pggb25 commented Jan 26, 2026

Summary

This PR allow to set 0 as min instance for KEDA auto scaling. For static and HPA autoscaler, the min instance is still 1
preview env: https://p80-z7aefc957-z79115c75-gtw.zc531a994.rustrocks.cloud/
application example: https://p80-z7aefc957-z79115c75-gtw.zc531a994.rustrocks.cloud/organization/460616f0-94da-4d35-b631-6fa4ed08eb9a/project/1b4c6a0f-ddd2-4b59-bd4d-19dcc7084c4c/environment/68d34366-d456-4e7b-a6ee-21e9e9eee7af/application/95b47f9d-5fab-46e4-9013-075a6c488da6/settings/resources

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • [ w] yarn format
  • [ x] yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • [x ] I performed a self-review (diff inspected, dead code removed)
  • [x ] I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.11%. Comparing base (69234ca) to head (af89f1f).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...src/lib/keda/components/instances-range-inputs.tsx 0.00% 0 Missing and 2 partials ⚠️
...ources-feature/page-settings-resources-feature.tsx 0.00% 0 Missing and 2 partials ⚠️
...tings-resources/application-settings-resources.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2332      +/-   ##
===========================================
+ Coverage    47.42%   49.11%   +1.69%     
===========================================
  Files         1265      686     -579     
  Lines        23317    14926    -8391     
  Branches      6869     4458    -2411     
===========================================
- Hits         11057     7331    -3726     
+ Misses       10131     6197    -3934     
+ Partials      2129     1398     -731     
Flag Coverage Δ
unittests 49.11% <0.00%> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pggb25 pggb25 merged commit c81f0a5 into staging Jan 26, 2026
10 checks passed
@pggb25 pggb25 deleted the feat/keda-cluster branch January 26, 2026 15:58
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.273.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants