Merged
Conversation
which... - segfaulted when setMaxNumReportedItems(1,1) was called - printed one more bottom/right quadrant item (rather than top/left) when setMaxNumReportedItems(odd,odd) This patch re-prioritises the top/left items (more intuitive to the user), printing the very first item when setMaxNumReportedItems(1,1). Note an insignificant bug remains in that case; ellipsis isn't printed. See issue #588
Previously, reportScalar(..., qreal) would ignore the user's significant figures as set by setMaxNumReportedSigFigs. This was because the routine invoked the templated printer_toStr() as defined in the printer.hpp header. Now, a qreal-specific printer_toStr overload is defined in printer.cpp source which considers sig-figs.
Previously, when the user set setNumReportedNewlines(0), validly called a single-line reporter (like reportPauliStr) but then invoked a validation error, the error message would begin on the same line as the previous output, causing visual confusion/noise. Now, the default validation error message begins with a newline so "half-printed lines" get interrupted before the message.
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.