RPATH handling and installation paths fix#601
RPATH handling and installation paths fix#601TysonRayJones merged 11 commits intoQuEST-Kit:develfrom eessmann:rpath-fix
Conversation
Adjusts install interface paths to use CMAKE_INSTALL_INCLUDEDIR and adds RPATH handling using helper function setup_quest_rpath. Ensures consistent RPATH behavior across platforms
|
Wew thanks very much for looking at this! Could you PR this instead to the |
|
Sure, no problem |
|
Thanks very much! Btw do you think it's worth testing execution of the executables compiled during CI? The compiled examples (at least, those in If that's worthwhile, we could bundle the workflow change into this PR to test these build changes "for free". It should be as simple as adding code like below to the bottom of # attempt to run the compiled executable, testing e.g. DLL location
- name: Run
if: ${{ matrix.os == 'windows-latest' }}
shell: bash
run: |
./${{ env.build_dir }}/examples/isolated/Release/complex_arithmetic_c.exe
- name: Run
if: ${{ matrix.os != 'windows-latest' }}
run: |
./${{ env.build_dir }}/examples/isolated/complex_arithmetic_cIf you think it's a good idea, I'll PR to your |
|
I think it's a great idea to run an isolated exe for a few secs in CI. It should catch most link time errors |
specifically the `complex_arithmetic_c` example. This serves just to check for link-time errors due to problems in the build
since 'complex_arithmetic_c' was actually disabled on Windows and so output nothing, hehe!
Hi Tyson
This code adjusts the install interface paths to use CMAKE_INSTALL_INCLUDEDIR and adds RPATH handling using the helper function setup_quest_rpath. This ensures consistent RPATH behaviour across platforms.
Erich