v3 Extend Pauli rotations to accept complex angles #594 (unitaryhack2025)#637
v3 Extend Pauli rotations to accept complex angles #594 (unitaryhack2025)#637TysonRayJones merged 6 commits intoQuEST-Kit:develfrom
Conversation
|
LGTM! Ignore the failing CI - that's due to something unrelated breaking in the installation of the ROCm compiler. As you'll have noticed, this UH challenge turned out way easier than expected after fleshing out the issue, boiling down to merely changing a type and copy/pasting a body. That's totally fine - you've earned the challenge! - but does mean I'm going to be pedantic :^) So could you please:
I actually tried to do all three myself but don't have permission to write directly to your fork 🙏 |
|
Perfect! You've completed the challenge to my satisfaction - I'll assign it to you now 🎉 I won't merge this PR yet since I'll quickly follow it with unit tests and want to keep the reminder active. So please keep this PR open! |
|
Oops, please leave a quick comment on Issue #594 so that I can award it to you 🙌 |
|
@diogomaia00 Are you happy to be included in QuEST's authorlist, and do you have a preferred name over your github handle? |
Yes of course, that’s very generous of you. Thank you. I’d prefer you to use Diogo Pratas Maia if it’s not to much :) |
and added Mai to memory.cpp authorlist as previously forgotten
My bad for the errors made
I’ve decided to make another PR, hope this time will work:
Thanks for the patience and help