Merged
Conversation
More renaming of internal entities are necessary though: - template parameter names in (c|g)pu_subroutines for consistency - operations.cpp unit tests template names - unit test evolution utilities function names
see previous commit for outstanding internal renaming
Member
Author
|
Now considering: applyX();
leftapplyX();
rightapplyX(); |
to (left|right)applyReferenceOperator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a premature PR just to run unit-tests while actual renames are deliberated. It is now easier to all-replace
preapplyandpostapplythan it was to replacemultiplyandpostMultiply(since the former collided with generic usage in comments)