refactor: simplify if statement#16
Open
deepsource-autofix[bot] wants to merge 1 commit into
Open
Conversation
This PR refactors the way the `isAdmin` flag is assigned by collapsing a multi-line `if-else` into a single, concise boolean expression.
- if statement can be simplified: Previously, the code checked for an "Admin" attribute and explicitly set `isAdmin` to `True` or `False` in an `if-else` block. This was redundant since the condition itself evaluates to a boolean. The fix replaces the block with `isAdmin = bool("Admin" in event["request"]["userAttributes"] and event["request"]["userAttributes"]["Admin"])`, making the intent clearer and the code more concise.
> This Autofix was generated by AI. Please review the change before merging.
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the way the
isAdminflag is assigned by collapsing a multi-lineif-elseinto a single, concise boolean expression.isAdmintoTrueorFalsein anif-elseblock. This was redundant since the condition itself evaluates to a boolean. The fix replaces the block withisAdmin = bool("Admin" in event["request"]["userAttributes"] and event["request"]["userAttributes"]["Admin"]), making the intent clearer and the code more concise.