Improve decoding performance by reducing new string creation#13
Merged
martincivan merged 1 commit intoQualityUnit:masterfrom Jun 5, 2023
Merged
Conversation
martincivan
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriting strings constantly uses a lot of memory and slows decoding considerably. There was also a place where a large string was built incrementally. A test was broken as well (trailing null byte in a filename) and there were several test warnings in PHPUnit 10.2.
I've fixed the tests and done the minimal changes necessary to get rid of the slow string operations. I don't have benchmarks on the speed improvements but the timeouts we were seeing for mail delivery have disappeared so it is certainly faster and should also be much more resource efficient.