Revert to string concatenation for decompression#17
Merged
martincivan merged 1 commit intoQualityUnit:masterfrom Jul 17, 2023
Merged
Revert to string concatenation for decompression#17martincivan merged 1 commit intoQualityUnit:masterfrom
martincivan merged 1 commit intoQualityUnit:masterfrom
Conversation
Author
|
@martincivan please do not interpret this as any pressure whatsoever, but would you be able to give me a time estimate for reviewing and merging this? We have a medium-priority performance issue ingesting some emails so if it will be a while I'll update and use our fork rather than wait. Thanks! |
Contributor
|
@bartbutler I am sorry, I was on a vacation and completely missed this notification. |
Author
|
I figured it was something like that. No problem at all, and thanks for being so responsive! |
martincivan
approved these changes
Jul 17, 2023
Contributor
|
@bartbutler released in v1.2.5 |
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some benchmarks and realized that for decompression string concatenation is much more memory-efficient and slightly faster than building an array followed by implode().