Skip to content

added missing office types to extension mime type map#18

Merged
martincivan merged 1 commit intoQualityUnit:masterfrom
alperenersoy:improv/office-mime-types
Jul 25, 2023
Merged

added missing office types to extension mime type map#18
martincivan merged 1 commit intoQualityUnit:masterfrom
alperenersoy:improv/office-mime-types

Conversation

@alperenersoy
Copy link

hey! we have just started to use your package. thanks for that. in this pr just added some missing mime types for microsoft office extensions.

@martincivan martincivan merged commit 9b792f3 into QualityUnit:master Jul 25, 2023
@martincivan
Copy link
Contributor

@alperenersoy thank you for your contribution, released in 1.2.6

@alperenersoy
Copy link
Author

@martincivan thanks! as i see the jpegs are mapped as image/pjpeg. are there any specific reasons for it instead of using image/jpeg?

@martincivan
Copy link
Contributor

@alperenersoy I have no idea... this is how it was in the original Squirellmail plugin that I extracted the logic from.

@martincivan
Copy link
Contributor

perhaps there exists some library that has these file-extension <> mime-type data more complete / in better shape, I haven't looked into it as I didn't notice any problem with this in our use-case.

@alperenersoy
Copy link
Author

@martincivan in #19 replaced them with generic image/jpeg. and added some mime types for common extensions.

@alperenersoy alperenersoy deleted the improv/office-mime-types branch July 26, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants