added missing office types to extension mime type map#18
Merged
martincivan merged 1 commit intoQualityUnit:masterfrom Jul 25, 2023
Merged
Conversation
martincivan
approved these changes
Jul 25, 2023
Contributor
|
@alperenersoy thank you for your contribution, released in |
Author
|
@martincivan thanks! as i see the jpegs are mapped as |
Contributor
|
@alperenersoy I have no idea... this is how it was in the original Squirellmail plugin that I extracted the logic from. |
Contributor
|
perhaps there exists some library that has these file-extension <> mime-type data more complete / in better shape, I haven't looked into it as I didn't notice any problem with this in our use-case. |
Author
|
@martincivan in #19 replaced them with generic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey! we have just started to use your package. thanks for that. in this pr just added some missing mime types for microsoft office extensions.