Skip to content

Conversation

@LouisSzeto
Copy link
Contributor

No description provided.

return true;
}

public void GenerateUniverseFiles()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's return a boolean, and return false with the exception.

{
// Run the data downloader/converter.
var success = instance.Run();
/*var success = instance.Run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this comment.
We need to check if it's a success for both and return exit(1) if one fails

var success = instance.Run();
if  (!success)
{
    Log.Error($"QuantConnect.DataProcessing.Program.Main(): Failed to download/process {CoinGeckoUniverseDataDownloader.VendorName} data");
}
if (!instance.GenerateUniverseFiles())
{
    Log.Error($"QuantConnect.DataProcessing.Program.Main(): Failed to generate {CoinGeckoUniverseDataDownloader.VendorName} universe");
   success = false:
}
if (!success) Environment.Exit(1);

@AlexCatarino AlexCatarino merged commit 7b8f7a5 into QuantConnect:master Jun 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants