Skip to content

Conversation

@Martin-Molinero
Copy link
Member

Description

  • Make sure calling CSharp methods, fields, properties releases the GIL, this was not happening for fields & properties, adding unit test reproducing the issue

See QuantConnect/pythonnet#91

Related Issue

Closes #7925

Motivation and Context

Deadlock

Requires Documentation Change

N/A

How Has This Been Tested?

Unit test reproducing issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero force-pushed the bug-7925-totalportfoliovaluee-python-deadlock-v2 branch from 0782f94 to d9eb31b Compare April 23, 2024 14:27
- Make sure calling CSharp methods, fields, properties releases the GIL,
  this was not hapenning for fiels & properties, adding unit test
  reproducing the issue
@Martin-Molinero Martin-Molinero force-pushed the bug-7925-totalportfoliovaluee-python-deadlock-v2 branch from d9eb31b to 46e3e89 Compare April 23, 2024 15:03
@Martin-Molinero Martin-Molinero merged commit 6d96097 into QuantConnect:master Apr 23, 2024
@Martin-Molinero Martin-Molinero deleted the bug-7925-totalportfoliovaluee-python-deadlock-v2 branch April 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deadlock in algorithm when using a custom security initializer

2 participants