Skip to content

Avoid bounds violation with 0-degree Cheb. polynomial.#48

Open
isutoris wants to merge 2 commits intoQuantEcon:masterfrom
isutoris:pull-request/fbbe5785
Open

Avoid bounds violation with 0-degree Cheb. polynomial.#48
isutoris wants to merge 2 commits intoQuantEcon:masterfrom
isutoris:pull-request/fbbe5785

Conversation

@isutoris
Copy link

Fixes bounds violation when evaluating 0-th degree Chebyshev polynomial by treating the case separately. Should fix #47.

@sglyon
Copy link
Member

sglyon commented Feb 12, 2018

Thanks for submitting this @isutoris !

Would you be willing to add a tests case that covers your usage (minus the ForwardDiff part)?

@codecov-io
Copy link

codecov-io commented Feb 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9fd30c6). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage          ?   91.01%           
=========================================
  Files             ?       12           
  Lines             ?     1346           
  Branches          ?        0           
=========================================
  Hits              ?     1225           
  Misses            ?      121           
  Partials          ?        0
Impacted Files Coverage Δ
src/smol_util.jl 97.69% <33.33%> (ø)
src/cheb.jl 82.07% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd30c6...e4346b9. Read the comment docs.

@isutoris
Copy link
Author

Thanks for quick feedback. Yes, adding test seems like a good idea, I will try (although it may take me couple days to get to it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault with 0-degree polynomials and autodiff

3 participants