DOC: fix doxstring for compte_sequence in lqcontrol#157
DOC: fix doxstring for compte_sequence in lqcontrol#157
Conversation
|
@spencerlyon2 Just processing all open PRs. Is this still an issue? |
MarkovChain.simulate API change; random_state option added
|
Not sure. I'd have to look again. Want me to check it out? |
|
@spencerlyon2 there aren't many changes. It looks like you have converted to using |
|
I think it is still meaningful. In the docstring we claimed to be returning the w_t, but we were actually returning C * w_t Also the number of elements in the return value was incorrectly documented. |
|
Cool - I will replicate the changes and push them. On Thu, Aug 27, 2015 at 1:39 PM, Spencer Lyon notifications@github.com
|
|
@spencerlyon2 I rebased this change but it is failing the test. ======================================================================
FAIL: test_scalar_sequences (quantecon.tests.test_lqcontrol.TestLQControl)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/QuantEcon/QuantEcon.py/quantecon/tests/test_lqcontrol.py", line 61, in test_scalar_sequences
assert_allclose(x_1, x_seq[0, -1], rtol=1e-4)
File "/home/travis/miniconda/lib/python2.7/site-packages/numpy/testing/utils.py", line 1297, in assert_allclose
verbose=verbose, header=header)
File "/home/travis/miniconda/lib/python2.7/site-packages/numpy/testing/utils.py", line 665, in assert_array_compare
raise AssertionError(msg)
AssertionError:
Not equal to tolerance rtol=0.0001, atol=0
(mismatch 100.0%)
x: array([[ 0.146818]], dtype=float32)
y: array(0.932981936024652) |
|
@mmcky sorry, I don't really have time to track down the error. |
implement changes from PR #157 to fix lqcontrol docstring
Wasn't true!