Remove code that supported optional numba installation#251
Merged
Conversation
Contributor
Author
|
In #246 It was resolved to remove the python2.7 range statements and to keep the |
Contributor
Author
|
I will leave this open for a day - in case there are any comments on the final diff. |
| #-Check if Numba is Available-# | ||
| from .util import numba_installed, jit | ||
|
|
||
| #TODO: Should this be specified with (nopython=True?) |
Member
There was a problem hiding this comment.
@jit(nopython=True) will work if the line A = np.asarray(A) is removed (assuming that the input A is an numpy ndarray). (But I suspect we wouldn't get much speedup.)
Contributor
Author
There was a problem hiding this comment.
Thanks @oyamad Agree. Let's leave this as is.
Contributor
Author
|
Thanks for your comments @oyamad. I will now remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes code that was written to support environments that did't have
numbainstalled. Now thatnumbais a strict dependency of the package - this code can now be removed. This will simplify how code is written etc.Updates:
markov/gth_solveshould we remove the following given support for Python 3.5+:gth_solveso as not to change the code to much, I have added ause_jitheader to the function signature to allow one to optionally use numpy. @oyamad Is this ok?Deprecations:
numba_installedpackage wide variable is no longer available.