improve dependency fetcher with clearer parameters#279
Merged
Conversation
Member
|
Yes, this is roughly what I had in mind. I think the dictionary behavior for It would be nice if we could have someone write a short example of fetching files from each of the different repositories and include it in the documentation for this function to make it easier for others to put this function to work. |
Contributor
Author
|
Before I merge this I really should write a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oyamad Once this is merged -- unfortunately this will break the notebook. But I think you guys are right -- this will be clearer to use.
@cc7768 Is this what you mean re issue #278?