Skip to content

Fix class style#321

Merged
jstac merged 1 commit intomasterfrom
classfix
Aug 4, 2017
Merged

Fix class style#321
jstac merged 1 commit intomasterfrom
classfix

Conversation

@lbui01
Copy link
Copy Markdown
Contributor

@lbui01 lbui01 commented Aug 4, 2017

This PR changes the class style (issue: jstac/QuantEcon.lectures#497).

Specifically, the PR changes class Foo(object): to class Foo:.

Note: object used to be required to provide some class infrastructure like super and @property in python2.7 which is no longer required in python3.X as inheritance of these things are now implicit.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 92.188% when pulling bee9850 on classfix into c1a5521 on master.

@jstac
Copy link
Copy Markdown
Contributor

jstac commented Aug 4, 2017

Thanks @lbui01

@jstac jstac merged commit 1b5dc19 into master Aug 4, 2017
@jstac
Copy link
Copy Markdown
Contributor

jstac commented Aug 4, 2017

@mmcky Sorry, I thought this was still lecture code, not QuantEcon.py!

Are you OK with these changes? It means we're no longer supporting 2.x, but perhaps that was already the case?

If you are OK I'll leave you to delete the branch.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Aug 4, 2017

@jstac this is fine. QuantEcon.py only supports 3.5+ as of version 0.3.3.

@mmcky mmcky deleted the classfix branch August 4, 2017 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants