Conversation
Contributor
|
thanks @oyamad. Sorry I have been off grid for a couple of weeks. I will merge this later today. |
Member
Author
|
@mmcky No problem at all! |
Contributor
Member
Author
|
@mmcky These PRs are independent. Either PR can be merged first. |
Contributor
|
@oyamad when you get a chance would you mind reviewing this merge conflict. Thanks. |
Numba jit version of scipy.special.comb
Using num_compositions_jit which uses comb_jit
Member
Author
|
@mmcky Rebased on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comb_jit, Numba jit version ofscipy.special.combReturns
0if the outcome exceeds the maximum value ofnp.intpnum_compositions_jitwhich usescomb_jitsimplex_gridin nopython mode usingnum_compositions_jit