Conversation
in util/combinatorics.py
instead of _next_k_combination and _next_k_array
Contributor
|
thanks @oyamad I like the approach to using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement
next_k_arraywhich is now based on "Algotirhm T" in Generating All Combinations by Knuth.Add
k_array_rankandk_array_rank_jit:k_array_rankworks with pure Python's arbitrary precision integer.k_array_rank_jitis Numba jit compiled and limited by the range ofnp.intp._next_k_arrayinsupport_enumerationis replaced by the newnext_k_array:_next_k_arrayis implemented by "Gosper's hack" (see game_theory: Add support_enumeration #263 (comment)) which has a limit in the size of the input array by the number of bits ofnp.int.next_k_arrayhas no such limitation.