Fix flake8 errors by rht · Pull Request #470 · QuantEcon/QuantEcon.py

rht · 2019-01-03T00:55:34Z

In particular:

E501 (line too long, not all)
E231 (whitespace stuff)
F405 (import wildcard)
F841 (unused vars, this requires manual review)

coveralls · 2019-01-03T01:16:24Z

Coverage decreased (-0.008%) to 93.891% when pulling a50612c on rht:F401 into a72b98a on QuantEcon:master.

mmcky · 2019-01-03T02:15:41Z

        bounds = np.array([[-2., 2.],
                           [-2., 2.]])

+        # TODO: why is `bounds` not passed to the argument here?


@QBatista would you have time to check this? (previously tagged @cc7768 -- sorry)

mmcky · 2019-01-03T02:18:42Z

        thetah = np.array([[1]]) - deltah
        ub = np.array([[30, 0, 0]])
-        x0 = np.array([[5, 150,1,0,0]]).T
+        # x0 = np.array([[5, 150, 1, 0, 0]]).T  # unused


@natashawatkins would you have time to check this?

it's not used anywhere else in this file, but I can't figure out why it's there in the first place

mmcky · 2019-01-03T02:19:20Z


    def test_update_using_stationary(self):
-        A, Q, G, R = self.A, self.Q, self.G, self.R
+        # A, Q, G, R = self.A, self.Q, self.G, self.R  # unused


@natashawatkins would you have time to check this?

not used in this function - was probably just copied from above

mmcky · 2019-01-03T02:19:35Z


        f_answer = np.array([[-.95, -.95], [0., 0.]])
-        p_answer = np.array([[1., 0], [0., 0.]])
+        # p_answer = np.array([[1., 0], [0., 0.]])  # unused


@natashawatkins would you have time to check this?

doesn't appear to be used

mmcky · 2019-01-03T02:20:50Z

thanks @rht.

I have tagged a few contributors to check a few of the F841 commented lines to make sure they aren't needed.

mmcky · 2019-01-11T05:14:10Z

thanks for the updates @rht.
@natashawatkins are you able to review the unused code items tagged in this PR? If they are unused then we should delete them.

mmcky · 2019-01-18T01:38:57Z

@rht would you mind deleting the unused items that are current commented?

mmcky · 2019-01-18T01:39:04Z

thanks for review @natashawatkins

rht · 2019-01-18T01:45:55Z

Assuming that that means all the unused variables detected by F841: I have just removed them.

rht · 2019-01-18T01:48:13Z

There are few remaining,

./docs/sphinxext/ipython_console_highlighting.py:62:9: F841 local variable 'tblexer' is assigned to but never used
./quantecon/robustlq.py:246:18: F841 local variable 'Q' is assigned to but never used
./quantecon/robustlq.py:246:21: F841 local variable 'R' is assigned to but never used
./quantecon/robustlq.py:247:9: F841 local variable 'beta' is assigned to but never used
./quantecon/robustlq.py:385:9: F841 local variable 'Q' is assigned to but never used
./quantecon/robustlq.py:385:12: F841 local variable 'R' is assigned to but never used
./quantecon/robustlq.py:395:9: F841 local variable 'sig' is assigned to but never used
./quantecon/kalman.py:162:12: F841 local variable 'k' is assigned to but never used
./quantecon/lss.py:395:18: F841 local variable 'H' is assigned to but never used
./quantecon/dle.py:80:9: F841 local variable 'phiing' is assigned to but never used
./quantecon/dle.py:309:9: F841 local variable 'Cc' is assigned to but never used
./quantecon/game_theory/repeated_game.py:125:5: F841 local variable 'C' is assigned to but never used

but I have to keep the PR lean for now.

mmcky · 2019-01-18T03:57:17Z

OK - thanks @rht

rht added 5 commits January 3, 2019 00:19

Apply autopep8 -ir --select E501 quantecon/util

d14e7e4

Fix all E231 errors

954727c

Travis: Add E231 check

9108ce9

Apply autopep8 -ir --select E501 quantecon

439e577

Fix all F405 error and check on Travis

ed51e46

mmcky reviewed Jan 3, 2019

View reviewed changes

Comment thread quantecon/lss.py Outdated

mmcky reviewed Jan 3, 2019

View reviewed changes

oyamad reviewed Jan 3, 2019

View reviewed changes

Comment thread quantecon/game_theory/game_generators/tests/test_bimatrix_generators.py Outdated

rht added 2 commits January 18, 2019 01:43

Fix some of F841 errors

8df06b1

lss: Fix formatting of a ValueError

a50612c

rht force-pushed the F401 branch from c271260 to a50612c Compare January 18, 2019 01:43

mmcky merged commit 4518f66 into QuantEcon:master Jan 18, 2019

Uh oh!

Conversation

rht commented Jan 3, 2019

Uh oh!

coveralls commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mmcky Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmcky Jan 3, 2019

Choose a reason for hiding this comment

Uh oh!

natashawatkins Jan 18, 2019

Choose a reason for hiding this comment

Uh oh!

mmcky Jan 3, 2019

Choose a reason for hiding this comment

Uh oh!

natashawatkins Jan 18, 2019

Choose a reason for hiding this comment

Uh oh!

mmcky Jan 3, 2019

Choose a reason for hiding this comment

Uh oh!

natashawatkins Jan 18, 2019

Choose a reason for hiding this comment

Uh oh!

mmcky commented Jan 3, 2019

Uh oh!

Uh oh!

mmcky commented Jan 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmcky commented Jan 18, 2019

Uh oh!

mmcky commented Jan 18, 2019

Uh oh!

rht commented Jan 18, 2019

Uh oh!

rht commented Jan 18, 2019

Uh oh!

mmcky commented Jan 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Jan 3, 2019 •

edited

Loading

mmcky Jan 3, 2019 •

edited

Loading

mmcky commented Jan 11, 2019 •

edited

Loading