Add drift term keyword to markov.tauchen.#484
Merged
mmcky merged 1 commit intoQuantEcon:masterfrom May 24, 2019
Merged
Conversation
979d659 to
526a891
Compare
Contributor
|
@shizejin Great work and great analysis. I was surprised the standard deviation wasn't a bit closer so I tried with m=4 and n=150. It was much better. (I remember now that the approximation actually gets worse when m gets large.) @mmcky I approve this PR. I would be glad if we could get this merged and a new version of QE.py released quickly to fix the bug @AnjuJoon found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to make
markov.tauchenable to handle non-zero drift term in the AR(1) process.Here discusses the logic of modification made.