Skip to content

Adds a rank size plot to inequality#518

Merged
mmcky merged 2 commits intomasterfrom
add_rank_size
Dec 8, 2019
Merged

Adds a rank size plot to inequality#518
mmcky merged 2 commits intomasterfrom
add_rank_size

Conversation

@jstac
Copy link
Copy Markdown
Contributor

@jstac jstac commented Dec 6, 2019

Generates a rank size plot from supplied data. This is quite useful and the code has been written to avoid new external dependences.

No test and I don't have time to write one now. Would appreciate if we can merge this subject to review and then think about proper tests later.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Dec 6, 2019

Hello @jstac! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:1: W191 indentation contains tabs
Line 11:1: W191 indentation contains tabs
Line 30:1: W191 indentation contains tabs
Line 42:80: E501 line too long (81 > 79 characters)
Line 43:1: W191 indentation contains tabs

Line 150:80: E501 line too long (80 > 79 characters)
Line 156:1: W391 blank line at end of file

Comment last updated at 2019-12-08 23:10:10 UTC

@jstac jstac requested a review from natashawatkins December 6, 2019 22:32
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 6, 2019

Coverage Status

Coverage decreased (-0.1%) to 93.952% when pulling 64a16f1 on add_rank_size into ad70e0e on master.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Dec 8, 2019

thanks @jstac this looks great.

@mmcky mmcky merged commit 7db60ff into master Dec 8, 2019
@mmcky mmcky deleted the add_rank_size branch December 8, 2019 23:22
@mmcky mmcky mentioned this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants