[Github actions] adding test github actions and adds test changes for pytest#548
[Github actions] adding test github actions and adds test changes for pytest#548
Conversation
still need to add test changes for this to work
|
@mmcky I still need to add in coveralls |
|
thanks @Harveyt47 -- if you can give me an update on this sometime that would be great. Thanks. |
|
Hey @mmcky look like I've got coveralls working and |
|
Perhaps the |
| - name: Run Tests | ||
|
|
||
| env: | ||
| COVERALLS_REPO_TOKEN: 7f8JDNk6BsPMESy0URL3W00zlazzRcuzR |
There was a problem hiding this comment.
Can you remind me what this REPO token is for?
Is this for travis to post the coverage results back to the REPO (or something else)?
We may need to rework this part for GitHub Actions.
|
@Harveyt47 this may be an issue re: coverage stats. so the token must be for this service.
If we don't need |
|
@Harveyt47 it looks like this is running the tests twice due to use of Best to set this up for |
|
thanks @Harveyt47 is there a way to get the Coveralls details as a comment on the PR? |
Using similar set up as to [here](https://github.com/marketplace/actions/coveralls-github-action)
|
Hi @mmcky I tried changing the Coveralls set up as I believe it thinks it using |
|
@Harveyt47 maybe we should remove the |
|
Can this be closed? |
|
I agree -- thanks @oyamad |
Creating test.yml. Still need to add test changes for this to work.