Skip to content

[Github actions] adding test github actions and adds test changes for pytest#548

Closed
Harveyt47 wants to merge 12 commits intomasterfrom
test-action
Closed

[Github actions] adding test github actions and adds test changes for pytest#548
Harveyt47 wants to merge 12 commits intomasterfrom
test-action

Conversation

@Harveyt47
Copy link
Copy Markdown
Member

Creating test.yml. Still need to add test changes for this to work.

still need to add test changes for this to work
@coveralls
Copy link
Copy Markdown

coveralls commented May 27, 2020

Coverage Status

Coverage decreased (-77.9%) to 16.034% when pulling 48011ac on test-action into 9d0fb5b on master.

@Harveyt47 Harveyt47 changed the title [GIthub actions] adding test github actions and adds test changes for pytest [Github actions] adding test github actions and adds test changes for pytest May 27, 2020
@Harveyt47 Harveyt47 requested a review from mmcky May 27, 2020 06:35
@Harveyt47
Copy link
Copy Markdown
Member Author

@mmcky I still need to add in coveralls

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Jun 9, 2020

thanks @Harveyt47 -- if you can give me an update on this sometime that would be great. Thanks.

@Harveyt47
Copy link
Copy Markdown
Member Author

Hey @mmcky look like I've got coveralls working and pytest passing. I'm not sure why the coverage is so low though

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Jun 10, 2020

Perhaps the .coveragerc file is not being used?

https://coverage.readthedocs.io/en/coverage-5.1/config.html

Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
- name: Run Tests

env:
COVERALLS_REPO_TOKEN: 7f8JDNk6BsPMESy0URL3W00zlazzRcuzR
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me what this REPO token is for?

Is this for travis to post the coverage results back to the REPO (or something else)?

We may need to rework this part for GitHub Actions.

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Jun 10, 2020

@Harveyt47 this may be an issue re: coverage stats.

PyYAML is not installed, skipping .coveralls.yml.
Submitting coverage to coveralls.io...
Coverage submitted!
Job #2e367460bc5316537ebbba8da13cf8f9b92d4ed4.1
https://coveralls.io/jobs/63716041

so the token must be for this service.

  • This means we should remove it and add it as a secret.
${{ secrets. COVERALLS_REPO_TOKEN }}

If we don't need .covearalls.yml then we should delete it

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Jun 10, 2020

@Harveyt47 it looks like this is running the tests twice due to use of pull_request and push

Best to set this up for pull_request and then a separate on: for push to - branch: master

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Jun 12, 2020

thanks @Harveyt47 is there a way to get the Coveralls details as a comment on the PR?

@Harveyt47
Copy link
Copy Markdown
Member Author

Hi @mmcky I tried changing the Coveralls set up as I believe it thinks it using travis-ci as the build type, as you can see when you click the link in the coveralls comment above. I think that's why the coverage was so low. I have used a new set up which is from the coveralls Github Actions marketplace page here

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Jan 2, 2021

@Harveyt47 maybe we should remove the yml file now that #561 has been merged and change this to be the PR to update tests for pytest

@oyamad
Copy link
Copy Markdown
Member

oyamad commented Apr 5, 2022

Can this be closed?

@mmcky
Copy link
Copy Markdown
Contributor

mmcky commented Apr 5, 2022

I agree -- thanks @oyamad

@mmcky mmcky closed this Apr 5, 2022
@mmcky mmcky deleted the test-action branch April 5, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants