Fix CI: bump @remix-run/* from 1.17 to 1.19 (peer dependency conflict)#29
Merged
Fix CI: bump @remix-run/* from 1.17 to 1.19 (peer dependency conflict)#29
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependency constraints to resolve CI install failures caused by a Remix v1 peer dependency mismatch, and applies targeted dependency overrides to reduce npm audit findings.
Changes:
- Bump
@remix-run/*packages from~1.17.0to~1.19.0to satisfy@myst-theme/site@0.14.0peer dependency requirements. - Add npm
overridesforprismjs,katex, andcytoscapeto address security advisories and maintain build compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@myst-theme/site@0.14.0 requires @remix-run/node@^1.19 as a peer dependency, but the project pinned ~1.17.0. This caused npm install to fail on CI (ERESOLVE) after recent dependency updates. Bumps all 6 @remix-run packages together: - @remix-run/node ~1.17.0 → ~1.19.0 - @remix-run/react ~1.17.0 → ~1.19.0 - @remix-run/vercel ~1.17.0 → ~1.19.0 - @remix-run/dev ~1.17.0 → ~1.19.0 - @remix-run/eslint-config ~1.17.0 → ~1.19.0 - @remix-run/serve ~1.17.0 → ~1.19.0 This is a minor version bump within Remix v1 (not the v2 migration tracked in #28). Build tested and passes.
mmcky
force-pushed
the
fix/remix-peer-deps
branch
from
0f45f51 to
5fd2daa
Compare
- Run npm audit fix for non-breaking dependency updates (23 vulns fixed) - Add npm overrides for transitive dependencies: - prismjs >=1.30.0 (fixes DOM Clobbering CVE) - katex >=0.16.21 (fixes 5 KaTeX CVEs) - cytoscape 3.30.4 (pin to version compatible with mermaid@9 exports) - Remaining 37 vulnerabilities require breaking changes: - Remix v2 migration (tracked in #28) - @myst-theme upstream updates (dompurify, nanoid, markdown-it) - @vercel/node major upgrade (ajv, esbuild, path-to-regexp) - tar v7 (incompatible with cacache@15)
mmcky
force-pushed
the
fix/remix-peer-deps
branch
from
5fd2daa to
f47f306
Compare
Contributor
Author
Addressing Copilot Review Feedback1. Unbounded override ranges — ✅ FixedUpdated overrides from
2.
|
mmcky
added a commit
that referenced
this pull request
Feb 25, 2026
mmcky
added a commit
that referenced
this pull request
Feb 25, 2026
mmcky
added a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI build failure caused by peer dependency mismatch and addresses npm security vulnerabilities.
Changes
1. Remix Peer Dependency Fix
Bumps all 6
@remix-run/*packages from~1.17.0to~1.19.0(still Remix v1):@remix-run/node,@remix-run/react,@remix-run/vercel(dependencies)@remix-run/dev,@remix-run/eslint-config,@remix-run/serve(devDependencies)Root cause:
@myst-theme/site@0.14.0declarespeerDependencyon@remix-run/node@^1.19, which conflicted with the project's~1.17.0pins, causingERESOLVEfailures on CI.2. Security Vulnerability Remediation
Reduced npm audit findings from 60 → 37 (23 fixed):
npm audit fix(non-breaking)overrides.prismjs >=1.30.0overrides.katex >=0.16.21overrides.cytoscape 3.30.4Remaining 37 Vulnerabilities (all require breaking changes)
These cannot be addressed without breaking changes and should be resolved as part of the Remix v2 migration (#28) and upstream @myst-theme updates.
Testing
npm install✅ (no ERESOLVE errors)npm run prod:build✅ (builds successfully, only pre-existing@myst-theme/site/srcdeep-import warning)npm auditconfirms 37 remaining (all require--force)