CategoricalMatrix column indexing#110
Merged
Merged
Conversation
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
requested a review
from Ben Thompson (tbenthompson)
as a code owner
3 tasks
Ben Thompson (tbenthompson)
approved these changes
Sep 22, 2021
Collaborator
Ben Thompson (tbenthompson)
left a comment
Ben Thompson (tbenthompson)
left a comment
There was a problem hiding this comment.
I think I mostly already reviewed this a part of the other PR. I looked through and I think this makes sense. I'm going to approve and merge.
Ben Thompson (tbenthompson)
pushed a commit
that referenced
this pull request
Oct 8, 2021
* categorical indexing * moved test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is inefficient, but adds a nice feature. I would suggests keeping this PR with the inefficient method and leave the improvement for a future work (see issue #101)
Checklist
CHANGELOG.rstentry