Fix bug in SplitMatrix matvec#154
Merged
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) merged 3 commits intomainfrom Nov 12, 2021
Merged
Fix bug in SplitMatrix matvec#154Marc-Antoine Schmidt (MarcAntoineSchmidtQC) merged 3 commits intomainfrom
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) merged 3 commits intomainfrom
Conversation
Jan Tilly (jtilly)
requested review from
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) and
Ben Thompson (tbenthompson)
Jan Tilly (jtilly)
requested a review
from Uwe L. Korn (xhochy)
as a code owner
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
approved these changes
Nov 12, 2021
Member
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
left a comment
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
left a comment
There was a problem hiding this comment.
Thanks! I'll apply the minor change I've suggested, merge, and publish a new release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.rstentryCloses #153. This fixes a regression that was introduced in #116. The optimization didn't correctly account for the case when the
SplitMatrixdidn't contain a dense component.