Add a message to the Exception in dense_sandwich#248
Merged
Marc-Antoine Schmidt (MarcAntoineSchmidtQC) merged 1 commit intoApr 21, 2023
Merged
Conversation
Fixes Quantco#208. Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Member
|
Thanks Julien Jerphanion (@jjerphan)! This was indeed pretty badly documented. I think it would make sense to check for contiguity as soon as possible. I would probably then print a warning and copy the array so it becomes contiguous. If the operation is too memory intensive, the user will see the warning and hopefully fix the root cause. We can still merge this fix asap and work on this further improvement in the future. |
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
approved these changes
Apr 11, 2023
Member
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
left a comment
Marc-Antoine Schmidt (MarcAntoineSchmidtQC)
left a comment
There was a problem hiding this comment.
Looks good!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208.
This is a simple fix.
I think that there are several alternatives if the provided array isn't contiguous:
DenseMatrixSparseMatrixSplitMatrixWhich one do you think is more appropriate?