feat!: Replace Subcircuit // take 3

[lmondada]

Hey Alan,

As promised, here is the subcircuit PR, rewritten to use CopyableExpr. This way subcircuits can be used to represent any valid SiblingSubgraph (indeed, a superset of SiblingSubgraph, as certain non-convex subgraphs are expressible too).

The convexity check will come in a separate PR.

BREAKING CHANGE: New API for Subcircuit, see docs. The Rewrite trait now takes a generic node argument.

[codecov]

Codecov Report

❌ Patch coverage is 70.19790% with 256 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.08%. Comparing base (d6d3324) to head (1eef17b).

Files with missing lines	Patch %	Lines
tket/src/subcircuit.rs	74.47%	168 Missing and 14 partials ⚠️
tket/src/resource.rs	2.43%	40 Missing ⚠️
tket/src/rewrite/strategy.rs	5.55%	17 Missing ⚠️
tket/src/resource/scope.rs	85.71%	5 Missing and 2 partials ⚠️
tket/src/portmatching/matcher.rs	33.33%	4 Missing ⚠️
tket/src/resource/types.rs	0.00%	2 Missing ⚠️
tket/src/rewrite.rs	83.33%	1 Missing and 1 partial ⚠️
tket/src/rewrite/trace.rs	0.00%	1 Missing ⚠️
tket/src/subcircuit/interval.rs	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##           lm/interval-pr    #1223      +/-   ##
==================================================
- Coverage           78.98%   78.08%   -0.90%     
==================================================
  Files                 154      155       +1     
  Lines               19244    19994     +750     
  Branches            18142    18892     +750     
==================================================
+ Hits                15199    15612     +413     
- Misses               3091     3419     +328     
- Partials              954      963       +9     

Flag	Coverage Δ
python	92.65% <ø> (ø)
qis-compiler	68.40% <ø> (ø)
rust	77.66% <70.19%> (-0.94%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lmondada]

Hi, is there a specific reason why this was closed? Or maybe this was automatic with the deletion of the lm/interval-pr...

In any case, @doug-q are you able to re-open this PR (I can't)? Otherwise I'll create a new one :)

[cqc-alec]

Hi, is there a specific reason why this was closed? Or maybe this was automatic with the deletion of the lm/interval-pr...

Probably the latter. It isn't possible to reopen this PR because the target branch has gone. I suggest creating a new one!