Fix translation operator in Ising CFT example#304
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
Author
|
@dartsushi, can you check that the plots here now give what you would expect? |
lkdvos
reviewed
Jul 3, 2025
Contributor
Perfect. Thanks for fixing those! |
lkdvos
approved these changes
Jul 4, 2025
Member
Author
|
I added two sentences on how the scaling dimensions relate to the excitation spectrum, and I updated the MPS plot to actually use the MPS data for Should be good to go now I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the translation operator in the Ising CFT example. This was (I assume) accidentally changed to the identity in #290, making all the momenta identically zero. Originally noticed by noticed by Meng Cheng, and reported by @tangwei94.
While I was at it, I changed the example checksum generation to use the relative path similar to what was done in QuantumKitHub/PEPSKit.jl#227. When attempting to rebuild the Ising example I noticed that it was actually rebuilding all of them, so seemed appropriate to squeeze this in here to prevent this in the future.