Skip to content

Generalize regauge! to AbstractVector#393

Merged
lkdvos merged 1 commit intoQuantumKitHub:mainfrom
AFeuerpfeil:pr-styles-ortho
Mar 1, 2026
Merged

Generalize regauge! to AbstractVector#393
lkdvos merged 1 commit intoQuantumKitHub:mainfrom
AFeuerpfeil:pr-styles-ortho

Conversation

@AFeuerpfeil
Copy link
Contributor

Generalize regauge! to work with AbstractVector instead of Vector.
(PS: In the current implementation of the algorithms, this is not an issue, as regauge! is either only called on single tensors like regauge!(AC, C; alg = alg_orth) or broadcasted like regauge!.(temp_Cs, temp_ACs).)

@lkdvos
Copy link
Member

lkdvos commented Feb 28, 2026

It might be reasonable to just delete this and always broadcast, but since it's already there I'm happy to keep it

@AFeuerpfeil
Copy link
Contributor Author

AFeuerpfeil commented Feb 28, 2026

Whatever you prefer, I don't have a clear preference.
Is there any situation where one might want to use the special vector version to multi-thread over the unit cell?
Then one could use the already existing OhMyThreads.jl interface.

@lkdvos lkdvos merged commit 0b6c65b into QuantumKitHub:main Mar 1, 2026
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants