Merged
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Now we have a `svd_trunc_with_err` that returns epsilon for those who wish, and `svd_trunc` returns only the truncated USVh
kshyatt
force-pushed
the
ksh/with_err
branch
from
7669475 to
ebffb20
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Jutho
reviewed
Dec 12, 2025
Jutho
reviewed
Dec 12, 2025
Jutho
reviewed
Dec 12, 2025
1 task
Jutho
reviewed
Dec 15, 2025
Jutho
reviewed
Dec 15, 2025
| alg_svd = select_algorithm(svd_compact!, A, alg; kwargs...) | ||
| return TruncatedAlgorithm(alg_svd, select_truncation(trunc)) | ||
| for f in (:svd_trunc!, :svd_trunc_no_error!) | ||
| @eval function select_algorithm(::typeof($f), A, alg; trunc = nothing, kwargs...) |
Member
There was a problem hiding this comment.
Can we do the Union{typeof(svd_trunc!), typeof(svd_trunc_no_error!)} again, or is there an advantage to this approach?
Member
Author
There was a problem hiding this comment.
Here I did it this way mostly to follow the convention above, not sure it matters much?
Jutho
reviewed
Dec 15, 2025
Member
|
Looks good to me! |
Jutho
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we have a
svd_trunc_with_errthat returns epsilon for those who wish, andsvd_truncreturns only the truncated USVh