Warn in case of real environments in :fixed mode#102
Merged
Conversation
lkdvos
reviewed
Dec 3, 2024
Collaborator
Author
|
I still need to add the actual full-infinite environment contractions, then I'll merge the CTMRG refactor once that's pushed and reviewed. |
Codecov ReportAttention: Patch coverage is
|
lkdvos
approved these changes
Dec 3, 2024
Yue-Zhengyuan
pushed a commit
to Yue-Zhengyuan/PEPSKit.jl
that referenced
this pull request
Dec 5, 2024
Warn in case of real environments in `:fixed` mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches the issue with real-valued environments and the
fixedoptimization mode, detected in #100. Thanks to @Yue-Zhengyuan for finding this!