Skip to content

CompatHelper: bump compat for Zygote to 0.7, (keep existing compat)#112

Merged
pbrehmer merged 10 commits intomasterfrom
compathelper/new_version/2025-01-05-01-17-00-994-03603044332
Jan 28, 2025
Merged

CompatHelper: bump compat for Zygote to 0.7, (keep existing compat)#112
pbrehmer merged 10 commits intomasterfrom
compathelper/new_version/2025-01-05-01-17-00-994-03603044332

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 5, 2025

This pull request changes the compat entry for the Zygote package from 0.6 to 0.6, 0.7.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@lkdvos
Copy link
Member

lkdvos commented Jan 6, 2025

This should be properly tested (as well as benchmarked), since that version of Zygote introduces the usage of @thunks, which were previously simply discarded.
It is expected that there might be some things that were incorrectly thunked or failed to unthunk, so these should be fixed, and it should hopefully be expected that this improves performance, and not hurts it.

@lkdvos lkdvos force-pushed the compathelper/new_version/2025-01-05-01-17-00-994-03603044332 branch from 80d9111 to 62bed6c Compare January 28, 2025 12:47
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/environments/ctmrg_environments.jl 63.15% <100.00%> (+0.39%) ⬆️
src/states/infinitepeps.jl 70.00% <100.00%> (+0.61%) ⬆️
src/utility/svd.jl 85.91% <100.00%> (+0.20%) ⬆️
src/utility/util.jl 52.63% <100.00%> (+0.50%) ⬆️

@pbrehmer
Copy link
Collaborator

This would be good to go for me once all test pass (seems to be the case locally). After that we could tag a new release :-)

@pbrehmer pbrehmer requested a review from lkdvos January 28, 2025 16:22
pbrehmer and others added 7 commits January 28, 2025 19:51
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
@pbrehmer pbrehmer enabled auto-merge (squash) January 28, 2025 19:26
@pbrehmer pbrehmer merged commit 4de9e09 into master Jan 28, 2025
27 checks passed
@pbrehmer pbrehmer deleted the compathelper/new_version/2025-01-05-01-17-00-994-03603044332 branch January 28, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants