Fix contraction order optimization for LocalOperator contractions#114
Merged
Fix contraction order optimization for LocalOperator contractions#114
LocalOperator contractions#114Conversation
Codecov ReportAttention: Patch coverage is
|
lkdvos
force-pushed
the
pb-fix-localoperator-contraction
branch
from
f9a1512 to
ad75752
Compare
lkdvos
approved these changes
Jan 10, 2025
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Good catch! I took the time to also just refactor the code a bit, there was quite a bit of duplication etc, I would argue it reads a lot nicer now.
If tests turn green, good to go for me!
Collaborator
Author
|
The refactor looks very nice, thanks for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fix the contraction order optimization in
_contract_localoperatorand_contract_localnormby renaming the indices and using@autoopt.