Conversation
|
This seems to work now, except for all the boundary MPS things. Note that we here update MPSKit, MPSKitModels, KrylovKit, VectorInterface, TensorKit and TensorOperations at once since that way it was easier to disentangle all the compat requirements. Once we get the boundary MPS things going, I'll take a look at the Zygote compat PR and merge that ASAP. |
|
This should be almost good to go I think. Boundary MPS contractions are running, and I took the liberty to reorganize and merge things as best I could right now. There's still some things I would like to do (e.g. update the contractions to use The MPSKit updates allow to remove a bit of redundant code here (e.g. additional derivative structs such as
then we can just remove most of the boundary MPS code here and things will still just work. But this requires some work on MPSKit in the future, for now this is good enough I think. |
lkdvos
left a comment
There was a problem hiding this comment.
Looks good to me! I left a few minor comments, and it looks indeed like it will be a lot nicer once we lift some of the type restrictions in MPSKit, but I like getting this merged already in the meantime.
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
There was a problem hiding this comment.
Apologies for having a second round of comments, this really should be my final ones :).
I think I would still like to see the one remark about type piracy resolved, and restore the KrylovKit compat. Otherwise good to go!
Given the recent changes, and the restoration of compatibility. How do we feel about tagging this as a new (breaking) release?
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
left a comment
There was a problem hiding this comment.
If CI passes, good to go for me
Sounds reasonable to me :-) But before that I would also like to bump the Zygote and OptimKit compat so that everything is up-to-date. I'll do that later today. |
|
Fair warning that the OptimKit update is not possible yet, since that has to trickle through MPSKit first. If the Zygote update does not yield too much of a headache, I'm okay with getting that in before tagging a release, but fixing that should not be a breaking change. |
This pull request changes the compat entry for the
MPSKitpackage from0.11to0.11, 0.12.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.