Wrap SU intermediate steps into functions#143
Wrap SU intermediate steps into functions#143Yue-Zhengyuan merged 1 commit intoQuantumKitHub:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
lkdvos
left a comment
There was a problem hiding this comment.
Overall looks good to me.
Something to consider in the future (separate PR) is the same as before: have you considered whether the "linear map" choices are the most convenient?
It seems like permuting everything to TensorMap{N,0} might lead to unnecessary permutations again.
I'll leave this PR open for a while and see if I can further optimize it. I already kind of lost track of it, as you can see that I didn't specify the number of codomain/domain indices for the reduced tensors |
|
@lkdvos Or, is it ok if I just merge this one as it is and consider the choice of codomain/domain in the next PR on the construction of bond environment? That can provide more context on which choice is the best |
lkdvos
left a comment
There was a problem hiding this comment.
I actually prefer it in separate PRs, as you can tell the small ones are a lot easier to review and get progress on :).
Ok to merge for me.
This PR refactors the simple update, so that some parts can be reused by full update / neighborhood tensor update in the future.