Refactor absorb_weight and use leftorth in _qr_bond#146
Refactor absorb_weight and use leftorth in _qr_bond#146Yue-Zhengyuan merged 5 commits intoQuantumKitHub:masterfrom
absorb_weight and use leftorth in _qr_bond#146Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
left a comment
There was a problem hiding this comment.
Thanks for the changes, looks more or less good to me. I don't really understand how leftorth and rightorth can behave that differently, unless we really are missing a twist somewhere, which is definitely possible.
I left some comments with suggested alterations, but feel free to give your opinion about them too, this is definitely not a requirement or anything.
|
I found the issue with If I use both (ignore the speed difference; variables are not controlled) It may be because the initialization is obtained using only |
|
This really seems to indicate that we are missing some twists somewhere though, because otherwise there is no other difference of gauge: |
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
left a comment
There was a problem hiding this comment.
Ok to go for me if positive reply on my last comment.
This PR refactors the function
absorb_weightand replace the direction labels t, r, b, l (borrowed from YASTN) with the existing constants NORTH = 1, etc.In addition, in
_qr_bondfor time evolution, I found that usingleftorthonly appears to be more numerically stable for some reason. So I want to make this change as well. Another possible advantage is that usingleftorthonly can help produce abondenvarounda,bthat is a linear map between "un-dualed" spaces, which can save some twists: