Split off norm-preserving vector retractions#160
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Mar 18, 2025
lkdvos
reviewed
Mar 18, 2025
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
previously approved these changes
Mar 18, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Ok for me if tests turn green :)
lkdvos
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits of the core norm-preserving retraction utilities for vectors as
vector_retractandvector_transport!, and updates the PEPS retractions to broadcast these across the unit cell. The motivation behind this is that I would like to reuse the core retraction tools when optimizing over generic vectors that support VectorInterface (e.g. a singleTensorMapor a plainVector{<:Number}) in settings where the state we're optimizing has additional structure and is therefore not a genericInfinitePEPS.I also noticed that the
utility/diffset.jlfile was still included, but is no longer used anywhere. Since I think we anyway intended to move away from that, I thought it would be appropriate to just remove it.