Remove unnecessary type restriction on _safe_pow#165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
|
Somehow the tests all ran out of time again, while this really shouldn't have changed anything. Any clue? |
|
Whoops that is really weird, I really have no idea why that should change anything. Perhaps that changed precompilation times? In any case that shouldn't make such a big difference. I'll try to find some time tomorrow... Edit: Or perhaps the CI ran on new package versions which changed execution/precompilation times significantly. |
|
Seems like this is unrelated to this change, so I'm okay with just merging this and trying to fix the time-outs in a different PR |
|
Alright, that's certainly fine by me. Then I would think the time-outs are related to different package versions. |
|
Seems like a Zygote thing, CI was running Zugote v0.7.5 here versus v0.7.4 in the latest run where all the tests passed. |
Here we loosen the restriction of the number type in
_safe_pow. This makes sense sincesdiag_powshould also work on complex diagonal tensor maps. (I need this for a niche application related to differentiating the SVD which has to do with extra phase freedom for complex SVDs.)