Skip to content

Remove unnecessary type restriction on _safe_pow#165

Merged
pbrehmer merged 3 commits intomasterfrom
pb-safe-pow
Mar 27, 2025
Merged

Remove unnecessary type restriction on _safe_pow#165
pbrehmer merged 3 commits intomasterfrom
pb-safe-pow

Conversation

@pbrehmer
Copy link
Collaborator

Here we loosen the restriction of the number type in _safe_pow. This makes sense since sdiag_pow should also work on complex diagonal tensor maps. (I need this for a niche application related to differentiating the SVD which has to do with extra phase freedom for complex SVDs.)

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/utility/util.jl 51.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Member

lkdvos commented Mar 26, 2025

Somehow the tests all ran out of time again, while this really shouldn't have changed anything. Any clue?

@pbrehmer
Copy link
Collaborator Author

pbrehmer commented Mar 26, 2025

Whoops that is really weird, I really have no idea why that should change anything. Perhaps that changed precompilation times? In any case that shouldn't make such a big difference. I'll try to find some time tomorrow...

Edit: Or perhaps the CI ran on new package versions which changed execution/precompilation times significantly.

@lkdvos
Copy link
Member

lkdvos commented Mar 27, 2025

Seems like this is unrelated to this change, so I'm okay with just merging this and trying to fix the time-outs in a different PR

@pbrehmer
Copy link
Collaborator Author

Alright, that's certainly fine by me. Then I would think the time-outs are related to different package versions.

@pbrehmer pbrehmer merged commit a347846 into master Mar 27, 2025
31 of 39 checks passed
@pbrehmer pbrehmer deleted the pb-safe-pow branch March 27, 2025 16:05
@leburgel
Copy link
Member

Seems like a Zygote thing, CI was running Zugote v0.7.5 here versus v0.7.4 in the latest run where all the tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants