Merged
Conversation
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
force-pushed
the
fermionic_boundaries
branch
from
748ff6a to
70acd42
Compare
lkdvos
commented
Apr 14, 2025
lkdvos
force-pushed
the
fermionic_boundaries
branch
from
d60ba6f to
28a2753
Compare
leburgel
reviewed
Apr 15, 2025
Member
leburgel
left a comment
leburgel
left a comment
There was a problem hiding this comment.
There's some accidental double twists due to the merge I think, and I would prefer the mpotensor converter to be a bit more in line with how we handle local sandwiches elsewhere, but looks great otherwise.
lkdvos
force-pushed
the
fermionic_boundaries
branch
from
60c3e43 to
28a2753
Compare
leburgel
reviewed
Apr 16, 2025
leburgel
approved these changes
Apr 18, 2025
Member
leburgel
left a comment
leburgel
left a comment
There was a problem hiding this comment.
I added the mpotensor converter to the tests, good to go now for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some missing parity matrices