Skip to content

Fix optimizer verbosity in fixedpoint algorithm selector#175

Merged
pbrehmer merged 5 commits intomasterfrom
pb-fix-verbosity
Apr 14, 2025
Merged

Fix optimizer verbosity in fixedpoint algorithm selector#175
pbrehmer merged 5 commits intomasterfrom
pb-fix-verbosity

Conversation

@pbrehmer
Copy link
Collaborator

Small fix for wrong relative verbosity in select_algorithm(fixedpoint, ...): we want to have optimizer output for each iteration if the global verbosity is 1.

@lkdvos
Copy link
Member

lkdvos commented Apr 11, 2025

Just out of curiosity, and to check that we are consistent:
In MPSKit and KrylovKit, I think we use:
0. no output

  1. warnings
  2. init and convergence
  3. iteration
  4. detailed iteration (subalgorithms output)
  5. ...

@pbrehmer
Copy link
Collaborator Author

In that case, PEPSKit is not really consistent with MPSKit and KrylovKit. Here, verbosity=1 will print optimization output at every iteration, verbosity=2 will additionally print CTMRG information. I guess then it would make more sense to make the verbosity consistent with the rest... Thanks for pointing that out!

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/algorithms/optimization/peps_optimization.jl 96.10% <ø> (ø)
src/algorithms/select_algorithm.jl 95.83% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pbrehmer pbrehmer merged commit 4802481 into master Apr 14, 2025
39 checks passed
@pbrehmer pbrehmer deleted the pb-fix-verbosity branch April 14, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants