Fix LocalOperator constructor for indices of type Tuple{Int,Int}#176
Merged
Fix LocalOperator constructor for indices of type Tuple{Int,Int}#176
LocalOperator constructor for indices of type Tuple{Int,Int}#176Conversation
Member
|
This is not something specific to |
Collaborator
Author
|
The thing that made it break was this line: for i in 1:length(inds)
@assert space(operator, i) == plattice[inds[i]]
endsince the tuples weren't splatted. |
lkdvos
approved these changes
Apr 11, 2025
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tuple-typed indices would lead to an error since the inner constructor uses a
PeriodicArray(which apparently can only be indexed usingCartesianIndices). Now, I convert tuple indices toCartesianIndicessuch that internally always the same type is used but users can still use tuple indices (which we also do in the docstring).