Fix row and column mismatch in correlation_length with unit cells#198
Merged
lkdvos merged 7 commits intoQuantumKitHub:masterfrom May 21, 2025
Merged
Fix row and column mismatch in correlation_length with unit cells#198lkdvos merged 7 commits intoQuantumKitHub:masterfrom
correlation_length with unit cells#198lkdvos merged 7 commits intoQuantumKitHub:masterfrom
Conversation
lkdvos
previously approved these changes
May 13, 2025
lkdvos
reviewed
May 13, 2025
Member
lkdvos
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. Any chance you could add a test to that would break before and no longer does now? No worries if not, it’s just better in the long run :)
Contributor
Author
|
This is only a fix for the unit cell coordinate. As mentioned in #199 , there is another issue with this function that requires further work. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
This reverts commit 75cf626.
Contributor
Author
Ready to merge! |
lkdvos
approved these changes
May 21, 2025
correlation_length with unit cells
lkdvos
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #197
The current fix also changes the definition of the correlation length: it includes the size of the unit cell inside. I am not sure about this change, I can discard it if it breaks MPSKit conventions.
I still think there is something wrong: in the AKLT case, this fix gives a correlation length around 1 when I believe it is around 2 (as published in https://link.aps.org/doi/10.1103/PhysRevB.96.121115), but I am less sure where the factor 2 is wrong.
I can add the AKLT case as a test, regardless of the factor 2 just to check if it executes.