Skip to content

Fix row and column mismatch in correlation_length with unit cells#198

Merged
lkdvos merged 7 commits intoQuantumKitHub:masterfrom
ogauthe:corr_length
May 21, 2025
Merged

Fix row and column mismatch in correlation_length with unit cells#198
lkdvos merged 7 commits intoQuantumKitHub:masterfrom
ogauthe:corr_length

Conversation

@ogauthe
Copy link
Contributor

@ogauthe ogauthe commented May 13, 2025

Fix #197

The current fix also changes the definition of the correlation length: it includes the size of the unit cell inside. I am not sure about this change, I can discard it if it breaks MPSKit conventions.

I still think there is something wrong: in the AKLT case, this fix gives a correlation length around 1 when I believe it is around 2 (as published in https://link.aps.org/doi/10.1103/PhysRevB.96.121115), but I am less sure where the factor 2 is wrong.

I can add the AKLT case as a test, regardless of the factor 2 just to check if it executes.

lkdvos
lkdvos previously approved these changes May 13, 2025
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. Any chance you could add a test to that would break before and no longer does now? No worries if not, it’s just better in the long run :)

@ogauthe
Copy link
Contributor Author

ogauthe commented May 14, 2025

This is only a fix for the unit cell coordinate. As mentioned in #199 , there is another issue with this function that requires further work.

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/algorithms/toolbox.jl 98.07% <100.00%> (-0.08%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogauthe
Copy link
Contributor Author

ogauthe commented May 21, 2025

  • recover MPSKit conventions on correlation length: unit cell size not included
  • do not bump version any more

Ready to merge!

@lkdvos lkdvos changed the title fix correlation length unit cell Fix row and column mismatch in correlation_length with unit cells May 21, 2025
@lkdvos lkdvos enabled auto-merge (squash) May 21, 2025 14:58
@lkdvos lkdvos merged commit db7ae37 into QuantumKitHub:master May 21, 2025
39 checks passed
@ogauthe ogauthe deleted the corr_length branch May 21, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SpaceMismatch in correlation_length from CTMRG

3 participants