Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
pbrehmer
approved these changes
Jun 13, 2025
Collaborator
pbrehmer
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing that and rerunning all the examples!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #200.
The problem being that the charge shift convention changed sign, so the example was trying to contract a PEPS at filling -1 instead of filling 1. Therefore, the norm of the PEPS was actually being correctly computed to be zero, which is an interesting effect since all of the tensors that are involved in the contraction still have norm 1.
In other words, while contracting a pepstensor with itself gives norm 1, as you contract an increasingly large patch the value tends to 0. Definitely an interesting effect!.
I reran all of the examples to update the docs accordingly.
Thanks to @ogauthe for telling me about this!