Skip to content

Fix charge convention in Fermi-Hubbard example#217

Merged
lkdvos merged 2 commits intomasterfrom
fermi
Jun 13, 2025
Merged

Fix charge convention in Fermi-Hubbard example#217
lkdvos merged 2 commits intomasterfrom
fermi

Conversation

@lkdvos
Copy link
Member

@lkdvos lkdvos commented Jun 12, 2025

This PR fixes #200.

The problem being that the charge shift convention changed sign, so the example was trying to contract a PEPS at filling -1 instead of filling 1. Therefore, the norm of the PEPS was actually being correctly computed to be zero, which is an interesting effect since all of the tensors that are involved in the contraction still have norm 1.

In other words, while contracting a pepstensor with itself gives norm 1, as you contract an increasingly large patch the value tends to 0. Definitely an interesting effect!.

I reran all of the examples to update the docs accordingly.

Thanks to @ogauthe for telling me about this!

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos enabled auto-merge (squash) June 12, 2025 17:01
@lkdvos lkdvos requested a review from pbrehmer June 12, 2025 19:36
Copy link
Collaborator

@pbrehmer pbrehmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing that and rerunning all the examples!

@lkdvos lkdvos merged commit 2b8403d into master Jun 13, 2025
45 checks passed
@lkdvos lkdvos deleted the fermi branch June 13, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PEPSKit 0.6.0: LAPACK error and CTMRG failure in Fermi-Hubbard example with symmetries

2 participants