Fix add_physical_charge for fermionic operators#253
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Do we have some kind of test coverage for this, or any way to actually check that things keep working properly in the meantime?
I'm definitely happy to keep things like this if that is just too much work for now, just wanted to ask.
|
The coverage is from the Bose-Hubbard test, so that doesn't catch this unfortunately. I removed the Fermi-Hubbard example test because the compilation time was ridiculous and always hitting the time limit. We could add a regression test that doesn't do any actual optimization but just checks operators directly. Maybe leave this open for now, I'll see if I can think of something tomorrow. |
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Cool, thanks for fixing and adding the tests!
2 participants
Fixes #259.
Instead of applying a
flipto the auxiliary space to get rid of the dual (which would also be correct I think), I decided to change the underlying contraction such that it no longer makes implicit assumptions on the auxiliary space.