Remove support for integer space specifiers in state and environment constructors#266
Merged
Remove support for integer space specifiers in state and environment constructors#266
Conversation
leburgel
changed the title
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
leburgel
changed the title
lkdvos
reviewed
Sep 29, 2025
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Overall definitely looks good, I like the simplification quite a bit
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #265.
I also tried to simplify the constructors a bit in the process by splitting out the filling of the physical and virtual spaces depending on how were provided. I at least removed a bunch of things, not sure if this actually made things simpler.