Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Test failures seem unrelated, something in the Lorentzian broadening test for the SVD pullback. Anything we should worry about @pbrehmer? |
No this seems unproblematic. I would assume that since we now obtain more accurate gradients due to #276 some of the SVD gradient values have changed. In that particular test that fails, the unbroadened gradient is now slightly more accurate when there are degenerate singular values but it is still deviating from the broadened gradients significantly (i.e. suffers from the same problem of divergences). I will just need to lower the tolerance slightly to make this stable again; I'll do that in #270 since there we anyway need to think about the SVD broadening again. |
No description provided.