Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
LinSolver to stabilize simple update into AD optimization testGMRES-based gradient solver to stabilize simple update into AD optimization test
GMRES-based gradient solver to stabilize simple update into AD optimization testGMRES-based gradient solver to stabilize simple update into AD optimization test
Member
Author
|
All the runners made it past the SU -> AD test without getting stuck at all, so this seems to solve the issue. We should probably understand better why GMRES doesn't struggle as much here, and if it's more stable in general maybe even switch the default linear solver from BiCGStab to GMRES. But at least this should already reduce the CI pressure. |
lkdvos
approved these changes
Oct 23, 2025
Member
|
I'll merge this without the tests, since they don't rerun due to the skip ci, and everything was passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to stabilize the test for running variational optimization on top of the simple update result for the Heisenberg model. It seems the gradient computation right at the start of the variational optimization is quite unstable, with both the
EigSolverandLinSolverusingKrylovKit.BiCGStabstruggling a lot causing the test to systematically time out in the CI on some configurations.The underlying reason for this might be that the simple update result has exact degeneracies in the SVD spectrum during the CTMRG projector computation, which causes trouble for the gradient computation in the first step. It seems that sometimes the optimization just cannot recover from this.
The problem is solved (at least locally for me) by switching to a
LinSolverusingKrylovKit.GMRES, which also takes a while to converge in the first step but seems more stable overall so the optimization can push through. While we should properly address the common issues with feeding an SU result into a variational optimization at some point, hopefully this at least fixes the CI issues for now.