Correct evolved time for bipartite simple update#291
Correct evolved time for bipartite simple update#291lkdvos merged 3 commits intoQuantumKitHub:masterfrom
Conversation
|
@pbrehmer If this PR looks good, please merge it before re-generating the example docs. |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
The macOS lts check that time out seems to be just a glitch. Windows and ubuntu checks are normal. Shall we consider moving the finite-T SU tests ( |
|
I'm happy to do so, but I would in the long run like to find some time to re-evaluate the tests in general. While it is definitely useful to include some of the examples and full runs as tests, it would be far superior to have smaller unit tests that don't take this long, or are less flaky/rng dependent. I have some ideas, just haven't found the time yet. I'll manually merge this PR though, since that would be better in a different PR anyways. |
This PR fixes the evolved time to
dtin one iteration of simple update for bipartite states.Previously, the
exp(-H dt)gate is applied twice to the each bond in one iteration of bipartite SU, making the evolved time2 * dt.