Skip to content

Correct evolved time for bipartite simple update#291

Merged
lkdvos merged 3 commits intoQuantumKitHub:masterfrom
Yue-Zhengyuan:fix-bipartite-pepo-su
Nov 16, 2025
Merged

Correct evolved time for bipartite simple update#291
lkdvos merged 3 commits intoQuantumKitHub:masterfrom
Yue-Zhengyuan:fix-bipartite-pepo-su

Conversation

@Yue-Zhengyuan
Copy link
Member

This PR fixes the evolved time to dt in one iteration of simple update for bipartite states.

Previously, the exp(-H dt) gate is applied twice to the each bond in one iteration of bipartite SU, making the evolved time 2 * dt.

@Yue-Zhengyuan
Copy link
Member Author

@pbrehmer If this PR looks good, please merge it before re-generating the example docs.

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/algorithms/time_evolution/simpleupdate.jl 97.70% <100.00%> (-2.30%) ⬇️
src/algorithms/time_evolution/time_evolve.jl 90.90% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yue-Zhengyuan
Copy link
Member Author

The macOS lts check that time out seems to be just a glitch. Windows and ubuntu checks are normal.

Shall we consider moving the finite-T SU tests (test/examples/j1j2_finiteT.jl and tf_ising_finiteT.jl) from the examples group to timeevol group to even out the running time of each test group?

@lkdvos
Copy link
Member

lkdvos commented Nov 16, 2025

I'm happy to do so, but I would in the long run like to find some time to re-evaluate the tests in general. While it is definitely useful to include some of the examples and full runs as tests, it would be far superior to have smaller unit tests that don't take this long, or are less flaky/rng dependent. I have some ideas, just haven't found the time yet. I'll manually merge this PR though, since that would be better in a different PR anyways.

@lkdvos lkdvos merged commit 91e59bf into QuantumKitHub:master Nov 16, 2025
50 of 51 checks passed
@Yue-Zhengyuan Yue-Zhengyuan deleted the fix-bipartite-pepo-su branch November 18, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants