Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
|
The 1.11 tests are still listed in the pending checks as "Expected". Will they automatically go away, or we need some manual clean-up? Other than this I'm OK to merge the PR. |
Member
Author
This is because they're set as 'required' in the repository settings. Specifying which workflows are required to pass is a very annoying manual thing to do. Once things pass here I'll remove the v1.11 versions from the required ones and add the v1 versions again instead. |
Yue-Zhengyuan
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of the segfaults that Zygote was throwing under Julia v1.12. It seems like the fix was a lot less scary than the error. Based on Jutho's digging here JuliaLang/julia#59138, I just put all the
@warns we have inside anignore_derviatives. Turns out there was really only one stray@warn, and explicitly ignoring it seems to have solved the problem. Still, Zygote is having all kinds of issues for Julia v1.12 (that we now no longer seem to suffer from), and it doesn't seem like any of these will be fixed soon (if at all).While this all feels a bit sketchy, since we're still quite a way from moving to a different AD engine I suggest to merge this and re-enable Julia v1.12 if tests pass here. If nothing else it will make tagging a whole lot easier, since the automerge decisions on the General registry are now running on Julia v1.12. In fact, my only real motivation for this PR is to fix the registration of v0.7.0 which can't be automerged because we restricted the Julia version.
If we agree and this is merged, I'll update the registration PR to get v0.7.0 released.